Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python refactor and simplification #2174

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Python refactor and simplification #2174

merged 2 commits into from
Jan 13, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 13, 2024

Thank you 🙏 for your contribution to Ultralytics 🚀! Your effort in enhancing our repositories is greatly appreciated. To streamline the process and assist us in integrating your Pull Request (PR) effectively, please follow these steps:

  1. Check for Existing Contributions: Before submitting, kindly explore existing PRs to ensure your contribution is unique and complementary.

  2. Link Related Issues: If your PR addresses an open issue, please link it in your submission. This helps us better understand the context and impact of your contribution.

  3. Elaborate Your Changes: Clearly articulate the purpose of your PR. Whether it's a bug fix or a new feature, a detailed description aids in a smoother integration process.

  4. Ultralytics Contributor License Agreement (CLA): To uphold the quality and integrity of our project, we require all contributors to sign the CLA. Please confirm your agreement by commenting below:

    I have read the CLA Document and I hereby sign the CLA

For more detailed guidance and best practices on contributing, refer to our ✅ Contributing Guide. Your adherence to these guidelines ensures a faster and more effective review process.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Updated code for improved efficiency and readability.

📊 Key Changes

  • Simplified code in export.py by directly passing file path without casting to string.
  • Changed list comprehension style in common.py for better readability.
  • Compact conditional logic in downloads.py.
  • Small indentation fix in ClearML README.md.
  • Optimized condition checks and used concise dictionary initialization in clearml_utils.py and other logger util files.
  • Refactored multiple if conditions into a single, cleaner condition in Comet logger utils for streamlined logic.

🎯 Purpose & Impact

  • The changes aim to make the codebase more maintainable and easier to understand.
  • For end-users, these modifications result in cleaner logs and potential minor performance improvements.
  • Developers will benefit from the increased clarity when maintaining or extending the code.

@glenn-jocher glenn-jocher changed the title Python code cleanup Python refactor and simplification Jan 13, 2024
@glenn-jocher glenn-jocher merged commit 2960a2d into master Jan 13, 2024
@glenn-jocher glenn-jocher deleted the code branch January 13, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants