Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links.yml #34

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Update links.yml #34

merged 1 commit into from
Jan 14, 2025

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 14, 2025

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Updated the workflow file to fix a file exclusion issue in link checks. πŸ”—βœ…

πŸ“Š Key Changes

  • Modified the file exclusion rule in .github/workflows/links.yml to exclude files named ci.yml instead of ci.yaml.

🎯 Purpose & Impact

  • Purpose: Correct a mismatch in file exclusion patterns, ensuring the link-checking workflow runs as expected.
  • Impact: Improves the reliability of the automated link-check workflow by correctly identifying and excluding the intended files. This helps maintain quality assurance in documentation and web assets. πŸš€

Signed-off-by: Glenn Jocher <[email protected]>
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
handbook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 14, 2025 0:29am

@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops fixed Bug has been resolved labels Jan 14, 2025
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting a ultralytics/handbook πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/handbook main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

For more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! πŸš€

This is an automated response to help streamline your PR review process. An Ultralytics engineer will review your submission shortly. 😊

@glenn-jocher glenn-jocher merged commit d123934 into main Jan 14, 2025
3 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch January 14, 2025 00:29
@UltralyticsAssistant
Copy link
Member

πŸŽ‰ Woohoo, your PR has been merged, @glenn-jocher! Thank you for tackling the file exclusion fine-tuningβ€”it’s such an elegant fix, but with a huge impact on keeping things sharp and reliable. πŸ”—βœ…

As Marcus Aurelius once said, "The impediment to action advances action. What stands in the way becomes the way." Your keen eye caught what was standing in the way and turned it into progress. πŸš€ Your contribution is part of building rock-solid workflows that help everyone move forward. Huge appreciation for your thoughtful work! πŸ™Œ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops fixed Bug has been resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants