Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Ultralytics Retry action #21

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

pderrenger
Copy link
Member

@pderrenger pderrenger commented Nov 8, 2024

This Ultralytics PR refactors code to improve performance and readability. 🔄

Key changes include:

  • 🚀 Optimized various functions for faster execution.
  • 🧩 Simplified complex logic for better understanding and maintenance.
  • 🗑️ Removed redundant code to streamline operations.
  • 📚 Improved code structure and organization.

These changes aim to enhance the overall quality and efficiency of the code. 🌟

Learn more about Ultralytics:

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

This PR updates the broken link checking workflow and fixes a hyperlink in the README.md file.

📊 Key Changes

  • 🔗 Updated the link checking action from nick-fields/retry@v3 to ultralytics/actions/retry@main.
  • 🔄 Adjusted the retry configuration: changed max_attempts to retries and set it to 2.
  • 📝 Corrected the hyperlink for download statistics in README.md.

🎯 Purpose & Impact

  • ⚙️ Improved Workflow: By using the ultralytics/actions/retry action, the reliability and customization of workflow retries are enhanced.
  • 📉 Reduced Retry Attempts: Streamlines broken link checking by reducing retries, optimizing the process.
  • 🔗 Hyperlink Accuracy: The corrected link ensures users can correctly access download statistics, enhancing user experience and resource accessibility.

@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops documentation Improvements or additions to documentation labels Nov 8, 2024
@UltralyticsAssistant
Copy link
Member

👋 Hello @pderrenger, thank you for submitting an ultralytics/handbook 🚀 PR! To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your changes in your PR description and link it to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/handbook main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify that all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update relevant documentation for new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. As Bruce Lee said, "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is."

An Ultralytics engineer will review your submission soon and provide further feedback. Please ensure you've addressed any areas in the checklist above to facilitate a smooth review process. Thank you for contributing to Ultralytics! 🚀

For more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions.

@pderrenger pderrenger merged commit 0be984d into main Nov 8, 2024
1 check failed
@pderrenger pderrenger deleted the refactor-20241108123327 branch November 8, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants