Do not set timer if no cache_time #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -106,6 +106,8 @@ def sleep(self): | |||
| def wake(self): | |||
| self.sleeping = False | |||
| cache_time = self.cache_time | |||
There was a problem hiding this comment.
stupid question, but why assign this to a new variable when we could use self.cache_time wherever needed in this function ?
There was a problem hiding this comment.
habit I suppose (lookup costs - not relevant here). do you want it changed?
|
As an aside the following modules do not have
|
|
Also, I confirm this fixes my xrandr login crash problem (but I guess I need to fix smthing in the module too) |
|
Thanks ! |
|
I think the issue here doesn't mean the xrandr module is broken |
|
no, but I can say it is broken with -12 error codes I don't understand :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #302 the problem appears to be when we wake a module that does not have its cache_time set
This PR checks for a cache_time value.