Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge of nullable params back into master repo #1

Merged

Conversation

mgrundkoetter
Copy link
Member

No description provided.

@mgrundkoetter mgrundkoetter merged commit 03ee928 into ujamii:master Jul 19, 2019
@bnf
Copy link
Contributor

bnf commented Aug 23, 2019

Thanks for merging our branch, much appreciated!

One note though, the branch relied on a open pull request in gossi/php-code-generator:
phpowermove/php-code-generator#64 – therefore I didn't open a pull request to your repository yet.

I should have added the patch to the composer.json in our nullable-getter-returndeclarations branch – anyway, here is a pull request to do that now:
#2
This fixes the API (re)generation. That change can be removed once gossi/php-code-generator merges the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants