Skip to content

Bl4 support - #4

Open
zarmstrong wants to merge 4 commits into
ugoogalizer:doco-updatefrom
zarmstrong:bl4
Open

Bl4 support#4
zarmstrong wants to merge 4 commits into
ugoogalizer:doco-updatefrom
zarmstrong:bl4

Conversation

@zarmstrong

@zarmstrong zarmstrong commented Sep 13, 2025

Copy link
Copy Markdown

This pull request adds support for "Borderlands 4" (bl4) to the project and updates documentation and code references to ensure consistency. The main changes include updating environment variables, documentation, and internal mappings to include bl4, as well as switching the source URL for the shiftcodes.json file to a new repository.

Borderlands 4 support:

  • Added bl4 to the default and example values for the SHIFT_GAMES environment variable in the Dockerfile and throughout the Readme.md documentation. [1] [2] [3] [4] [5]
  • Included bl4 in the internal mapping of supported games in query.py.
  • Updated the documentation table to list "Borderlands 4" and its code (bl4).

Source URL updates:

  • Changed the shiftcodes.json source URL in both Readme.md and query.py to point to the new repository at zarmstrong/autoshift-codes instead of ugoogalizer/autoshift-codes. [1] [2]

@zarmstrong

Copy link
Copy Markdown
Author

you'll need to update the shiftcodes json path and the scraper. i'll put in a pr for that repo too

@ugoogalizer

Copy link
Copy Markdown
Owner

Hey @zarmstrong , great work moving this forward. I haven't bought BL4 yet, but don't want to miss out on the codes. I'll spin up my environment again and start looking at this in the next day or two. Really keen to see where you've taken it.

@zarmstrong

Copy link
Copy Markdown
Author

I've made a lot more changes and committed them to master on my branch. also Fabbi posted that he will be working on this again soon... so I dunno what the future holds. 🤷🏼‍♂️

I just know that all my changes are working smoothly :)

@ugoogalizer ugoogalizer self-assigned this Sep 24, 2025
@ugoogalizer

Copy link
Copy Markdown
Owner

@zarmstrong I just had a flick through your work, you've been very busy, I am thrilled you've taken this another step forward! I am unsure myself on the right approach here not knowing what @Fabbi is thinking and whether it's worth merging yours back together with mine (probably not as then you lose agility), creating some kind of shared community repository or leaving it in your repo.

A shared/community repo could make it be a bit easier for a community to be responsive and maintain this in months/years ahead.

@Fabbi

Fabbi commented Sep 24, 2025

Copy link
Copy Markdown

I already started working on it and will come back to you. I'll integrate code from your repositories and possibly the scraper if that's okay with you two.

We can definitely make this into an shared project, too.

@ugoogalizer

Copy link
Copy Markdown
Owner

I already started working on it and will come back to you. I'll integrate code from your repositories and possibly the scraper if that's okay with you two.

We can definitely make this into an shared project, too.

Sounds great to me. No issue you integrating the scraper, noting my intent was to minimise the hits on mentalmars, each instance hitting it directly would add undue load on their servers.

Also of note I've wanted for some time to pull that json structure in the scraper that maps out the tables of ewch website into a standalone file to make it a bit easier to maintain - open to ideas though.

@zarmstrong

Copy link
Copy Markdown
Author

i currently have the scraper running on schedule as a github action that updates the json in my fork of the autoshift-codes repo (which is what my fork of autoshift points to)

Figured running it through gh actions would be safer than running on my home server, since i cant do the same uptime gh can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants