-
Notifications
You must be signed in to change notification settings - Fork 276
Scale-aware 3DTKE EDMF and TTE-EDMF GFS PBL related updates #2806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale-aware 3DTKE EDMF and TTE-EDMF GFS PBL related updates #2806
Conversation
3DTKE and TTE-EDMF GFS PBL related updates.
|
@BinLiu-NOAA Since this PR doesn't change any baselines, this means that no tests currently use this functionality? |
@grantfirl, Correct. We plan to update a HAFS regression test to use these 3DTKE related options in a later pull request. |
27d25d7 to
c3867ec
Compare
|
@BinLiu-NOAA can you sync up branches? We can start working on this pr. |
|
|
@BinLiu-NOAA we will schedule to work on #2584 as soon as all final reviews of the sub-component PRs are done. |
|
@JongilHan66 As I mentioned to you earlier, it turns out the following three RTs got the different results from the baseline: Not sure if this is something expected/accepted for this pull request. Thanks! |
@BinLiu-NOAA I've checked the PBL code again but cannot find a reason for the failed RT. Since it was well tested in GFS and HAFS, I don't think it has a problem. How about running the updated codes twice and comparing the two? |
|
@BinLiu-NOAA can you sync up branches? we can start working on this pr. |
Sure. Working on it... |
|
@jkbk2004 This PR and its related submodule PRs should be synced up now. Please be noted that new baseline needed for the following three RTs:
Thanks! |
@FernandoAndrade-NOAA, Sure, added/updated. |
|
I tested derecho modulefiles from #2863. It still see troubles with builds on derecho. we will skip derecho. we can start merging process. |
|
@BinLiu-NOAA new ufsatm hash is NOAA-EMC/ufsatm@22ffc20 |
@jkbk2004 Submodule updated. Thanks! |
Commit Queue Requirements:
Description:
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: