Skip to content

Conversation

@BinLiu-NOAA
Copy link
Contributor

@BinLiu-NOAA BinLiu-NOAA commented Jul 11, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

  • Scale-aware 3DTKE EDMF GFS PBL related updates/modifications and enable it being used with TTE-EMDF and use_lpt option. (from @JongilHan66, @zhup01, @samuelkyfung)

Commit Message:

* UFSWM - Scale-aware 3DTKE EDMF GFS PBL related updates/modifications and enable it being used with TTE-EMDF and use_lpt option. (from @JongilHan66, @zhup01, @samuelkyfung)
  * FV3 - Scale-aware 3DTKE EDMF GFS PBL related updates/modifications and enable it being used with TTE-EMDF and use_lpt option. (from @JongilHan66, @zhup01, @samuelkyfung)
    * ccpp-physics - Update scale-aware 3DTKE EDMF (from @JongilHan66, @zhup01, @samuelkyfung) and introduce TTE-EDMF in GFS PBL scheme (from @JongilHan66).
    * atmos_cubed_sphere - Scale-aware 3DTKE EDMF GFS PBL related updates/modifications from @JongilHan66, @zhup01, @samuelkyfung.

Priority:

  • Normal: 2025 HAFS real-time parallel related changes

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Documentation:

  • No documentation update is required for this PR (please explain).

Changes

Regression Test Changes (Please commit test_changes.list):

  • Baseline Change for the following RTs
    • cpld_control_p8_faster intel
    • control_p8_faster intel
    • hafs_regional_storm_following_1nest_atm_ocn_wav_inline intel

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@grantfirl
Copy link
Collaborator

@BinLiu-NOAA Since this PR doesn't change any baselines, this means that no tests currently use this functionality?

@BinLiu-NOAA
Copy link
Contributor Author

@BinLiu-NOAA Since this PR doesn't change any baselines, this means that no tests currently use this functionality?

@grantfirl, Correct. We plan to update a HAFS regression test to use these 3DTKE related options in a later pull request.

@BinLiu-NOAA BinLiu-NOAA force-pushed the feature/3dtke_update branch from 27d25d7 to c3867ec Compare July 28, 2025 22:44
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Aug 1, 2025

@BinLiu-NOAA can you sync up branches? We can start working on this pr.

@BinLiu-NOAA
Copy link
Contributor Author

@BinLiu-NOAA can you sync up branches? We can start working on this pr.
@jkbk2004, currently we are still working on finalizing some changes for this PR. Meanwhile, wondering if you could consider switching to give higher priority to PR #2584, which is another PR HAFS needs/uses for 2025 HAFS real-time parallel experiments and has been waiting in the commit queue for a while. Much appreciated!

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Aug 4, 2025

@BinLiu-NOAA we will schedule to work on #2584 as soon as all final reviews of the sub-component PRs are done.

@BinLiu-NOAA
Copy link
Contributor Author

BinLiu-NOAA commented Aug 23, 2025

@JongilHan66 As I mentioned to you earlier, it turns out the following three RTs got the different results from the baseline:

* TEST cpld_control_p8_faster_intel: FAILED: UNABLE TO COMPLETE COMPARISON
-- LOG: /scratch3/NCEPDEV/hwrf/save/Bin.Liu/uwm_3dtke_update/tests/logs/log_hera/run_cpld_control_p8_faster_intel.log
* TEST control_p8_faster_intel: FAILED: UNABLE TO COMPLETE COMPARISON
-- LOG: /scratch3/NCEPDEV/hwrf/save/Bin.Liu/uwm_3dtke_update/tests/logs/log_hera/run_control_p8_faster_intel.log
* TEST hafs_regional_storm_following_1nest_atm_ocn_wav_inline_intel: FAILED: UNABLE TO COMPLETE COMPARISON
-- LOG: /scratch3/NCEPDEV/hwrf/save/Bin.Liu/uwm_3dtke_update/tests/logs/log_hera/run_hafs_regional_storm_following_1nest_atm_ocn_wav_inline_intel.log

Not sure if this is something expected/accepted for this pull request. Thanks!

@JongilHan66
Copy link
Collaborator

/scratch3/NCEPDEV/hwrf/save/Bin.Liu/uwm_3dtke_update/tests/logs/log_hera/run_cpld_control_p8_faster_intel.log

@BinLiu-NOAA I've checked the PBL code again but cannot find a reason for the failed RT. Since it was well tested in GFS and HAFS, I don't think it has a problem. How about running the updated codes twice and comparing the two?

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 4, 2025

@BinLiu-NOAA can you sync up branches? we can start working on this pr.

@BinLiu-NOAA
Copy link
Contributor Author

@BinLiu-NOAA can you sync up branches? we can start working on this pr.

Sure. Working on it...

@BinLiu-NOAA
Copy link
Contributor Author

@jkbk2004 This PR and its related submodule PRs should be synced up now. Please be noted that new baseline needed for the following three RTs:

  • cpld_control_p8_faster intel
  • control_p8_faster intel
  • hafs_regional_storm_following_1nest_atm_ocn_wav_inline intel

Thanks!

@FernandoAndrade-NOAA FernandoAndrade-NOAA added Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Sep 4, 2025
@BinLiu-NOAA
Copy link
Contributor Author

@BinLiu-NOAA please fill out the commit message section of the PR template to summarize changes made in this PR, thank you.

@FernandoAndrade-NOAA, Sure, added/updated.

@FernandoAndrade-NOAA FernandoAndrade-NOAA added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ort run ORT testing In Testing The PR that is currently in testing stages labels Sep 4, 2025
@FernandoAndrade-NOAA FernandoAndrade-NOAA removed the jenkins-ort run ORT testing label Sep 5, 2025
@jkbk2004 jkbk2004 removed the In Testing The PR that is currently in testing stages label Sep 8, 2025
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 8, 2025

I tested derecho modulefiles from #2863. It still see troubles with builds on derecho. we will skip derecho. we can start merging process.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 8, 2025

@BinLiu-NOAA new ufsatm hash is NOAA-EMC/ufsatm@22ffc20

@BinLiu-NOAA
Copy link
Contributor Author

@BinLiu-NOAA new ufsatm hash is NOAA-EMC/ufsatm@22ffc20

@jkbk2004 Submodule updated. Thanks!

@FernandoAndrade-NOAA FernandoAndrade-NOAA merged commit e7ee38e into ufs-community:develop Sep 8, 2025
4 checks passed
@BinLiu-NOAA BinLiu-NOAA deleted the feature/3dtke_update branch November 26, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update 3DTKE EDMF GFS PBL and combine with TTE-EDMF

6 participants