Skip to content

Conversation

@MicroTed
Copy link
Contributor

@MicroTed MicroTed commented Apr 26, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR adds a doubly-periodic idealized "Process Model" capability to UFS-FV3 that is customizable by the user at run time via input.nml and that can be run within the UFS framework and is fully compatible with CCPP physics (GFS_PHYS=1). It allows a user to specify a horizontally homogeneous environment (single sounding) to run with any physics suite and grid configuration (dimensions, grid spacing, etc.). Surface and orographic input conditions can be generated by a python script (docs/ideal_processmodel_doc/create_ideal_sfc_oro_input.py) or read from real data files. The regression test runs an supercell storm simulation as a simple example. Two example suites of simplified physics are provided: One with clould microphysics only (used for RT), and another with added PBL physics.

This capability is distinct from the idealized dycore tests in test_cases.F90 (atmos_cubed_sphere). The new code is meant to work with UFS/CCPP and thus is kept separate in the driver/UFS directory and has an independent namelist. Documentation is added within atmos_cubed_sphere.

This work was led by @LarissaReames-NOAA, who did most of the coding. This PR replaces #2559 because unfortunately she cannot currently work on it.

A self-contained run directory that can be cloned by those who'd like to test the code inside a pre-generated run directory can be found here (will be updated to work with finalized code): https://github.com/MicroTed/ufs_ideal_run.git

Fixes/addresses #2558
Replaces #2559

Commit Message:

* UFSWM -  Adds a doubly-periodic "process model" capability to run physics in a simple environment
* UFSWM -  Ursa job card and test resource update
* UFSWM - Jenkins file update: ORT scratch3 and fix for platform log handling
  * FV3 - Adds a doubly-periodic "process model" capability to run physics in a simple environment
    * atmos_cubed_sphere - Adds a doubly-periodic "process model" capability to run physics in a simple environment
  * MOM6 - update MOM6 to its main repo. 20250801 commit

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Test (pm_ideal_supercell) with baseline (but maybe doesn't need baseline?) Baseline output on hera at /scratch1/BMC/gsd-fv3-dev/Ted.Mansell/ufs/rt/stmp4/Ted.Mansell/FV3_RT/REGRESSION_TEST/fv3_pm_supercell_intel

Input data Changes:

  • New input data (temporarily on hera at /scratch1/BMC/gsd-fv3-dev/Ted.Mansell/ufs/FV_PM_IDEAL/INPUT )
  • new input on baseline location: /scratch3/NAGAPE/epic/role.epic/UFS-WM_RT/NEMSfv3gfs/input-data-20250507/FV3_PM_ideal

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Ursa
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@MicroTed MicroTed marked this pull request as ready for review April 26, 2025 18:20
@jkbk2004
Copy link
Collaborator

@MicroTed can you sync up branches as well?

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Aug 4, 2025

@BrianCurtis-NOAA this pr is ready for full tests. new input: /scratch3/NAGAPE/epic/role.epic/UFS-WM_RT/NEMSfv3gfs/input-data-20250507/FV3_PM_ideal

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Aug 4, 2025

@BrianCurtis-NOAA FYI: new case pm_ideal_supercell is only on hera.

@FernandoAndrade-NOAA FernandoAndrade-NOAA added the jenkins-ort run ORT testing label Aug 4, 2025
@FernandoAndrade-NOAA FernandoAndrade-NOAA removed the jenkins-ort run ORT testing label Aug 5, 2025
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Aug 5, 2025

all tests are done ok. we can start merging process.

@jiandewang
Copy link
Collaborator

MOM6 merged, hash # 5c7d3b6

@jkbk2004 jkbk2004 removed the In Testing The PR that is currently in testing stages label Aug 5, 2025
Copy link
Collaborator

@NickSzapiro-NOAA NickSzapiro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TPN on Ursa is being set to different values across different tests. Can someone summarize how these were chosen?

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Aug 6, 2025

TPN on Ursa is being set to different values across different tests. Can someone summarize how these were chosen?

@NickSzapiro-NOAA Tests generally run more stably with slight increase of resource on ursa. But I still see a few cases sporadically cross wall clock time limit. I don't think actual core hours. Job completion time, I think. We will keep checking on ursa.

@jkbk2004 jkbk2004 merged commit ce74044 into ufs-community:develop Aug 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. Changes Existing Input Data Existing input data will be changed. A new input-data-YYYYMMDD directory must be created. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a user-friendly idealized testing capability

10 participants