TEMPO v3 with Prognostic Cloud Fraction#212
Open
AndersJensen-NOAA wants to merge 54 commits intoufs-community:gsl/developfrom
Open
TEMPO v3 with Prognostic Cloud Fraction#212AndersJensen-NOAA wants to merge 54 commits intoufs-community:gsl/developfrom
AndersJensen-NOAA wants to merge 54 commits intoufs-community:gsl/developfrom
Conversation
…loud fraction and cloud water
…physics driver, and to TEMPO driver
…d water and cloud fraction
- added graupel volume to init_atmosphere registry - formatted code
AndersJensen-NOAA
requested review from
clark-evans and
dustinswales
as code owners
joeolson42
reviewed
Feb 6, 2026
| cldfrabl_p(i,k,j) = cldfrac_bl(k,i) | ||
| ! cldfrabl_p(i,k,j) = cldfrac_bl(k,i) | ||
| cldfrabl_p(i,k,j) = max(qal(k,i), qai(k,i)) | ||
| qcbl_p(i,k,j) = qc_bl(k,i) |
Collaborator
There was a problem hiding this comment.
I'll add a comment here as a reminder to look into this further.
Collaborator
There was a problem hiding this comment.
if qal and qai are always present, this shouldn't be a problem, but they are tied to the new package, so I think we need a conditional here.
Collaborator
Author
There was a problem hiding this comment.
Fixed on line 819, where I overwrite cloud fraction.
- adds check for prognostic cloud fraction to pbl driver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title above should be a 1 line short summary of the pull request (i.e. what the project the PR represents is intended to do).
Enter a description of this PR. This should include why this PR was created, and what it does.
Testing and relations to other Pull Requests should be added as subsequent comments.
See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931
Priority Reviewers