TEMPO 1-moment (true) hail option#109
Closed
AndersJensen-NOAA wants to merge 32 commits intoufs-community:gsl/developfrom
Closed
TEMPO 1-moment (true) hail option#109AndersJensen-NOAA wants to merge 32 commits intoufs-community:gsl/developfrom
AndersJensen-NOAA wants to merge 32 commits intoufs-community:gsl/developfrom
Conversation
…_fzra * Adds accumulated freezing rain variable, frainnc
…d for variable definition
…rainnc_p) by config_tempo_fzra * Adds allocatable freezing rain variable to TEMPO driver
…PAS and MPAS_to_precip
AndersJensen-NOAA
changed the title
AndersJensen-NOAA
changed the title
AndersJensen-NOAA
changed the title
AndersJensen-NOAA
changed the title
Collaborator
Author
|
@clark-evans This PR is ready for review, though I'll leave it in draft stage for now since it must wait for #124 |
clark-evans
requested review from
barlage,
haiqinli,
joeolson42,
mdtoyNOAA and
tanyasmirnova
mdtoyNOAA
approved these changes
May 10, 2025
tanyasmirnova
approved these changes
May 12, 2025
haiqinli
approved these changes
May 12, 2025
joeolson42
approved these changes
May 12, 2025
Collaborator
|
@AndersJensen-NOAA is this ready to come off of draft mode (once directory paths are updated) since #124 has been merged? |
AndersJensen-NOAA
requested review from
clark-evans and
jderrico-noaa
as code owners
clark-evans
approved these changes
May 19, 2025
Collaborator
|
@AndersJensen-NOAA looks good to me, though it shows a conflict that needs to be resolved. I think it's due to our directory reorganization, though, which will be addressed anyway when you sync with the top of gsl/develop. |
barlage
approved these changes
May 28, 2025
| <package name="mp_tempo_in" description="parameterization of TEMPO cloud microphysics."/> | ||
| <package name="tempo_aerosolaware_in" description="variables for TEMPO aerosol-aware microphysics."/> | ||
| <package name="tempo_hailaware_in" description="variables for TEMPO hail-aware microphysics."/> | ||
| <package name="tempo_qh_in" description="variables for TEMPO microphysics with hail category."/> |
Collaborator
There was a problem hiding this comment.
just out of curiosity, is this added here for future use? there are no init_atmosphere variables associated with this package, right?
Collaborator
|
@AndersJensen-NOAA I am a little confused at why this is not showing more differences with gsl/develop since your base version seems to be 3.7 |
Collaborator
|
Will be superseded by #192. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a hail size diagnostic to TEMPO and the option to run TEMPO with a true (1-moment) hail category.
Testing and relations to other Pull Requests should be added as subsequent comments.
See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931
Information on running mandatory regression tests on Jet can be found here and the results pasted below.
regression test case results