Open
Conversation
There was a problem hiding this comment.
VERDICT: APPROVE
Summary:
- 新增了一个
Repo HealthcheckGitHub Actions 工作流(定时+手动触发)。 - 工作流覆盖依赖安装、
typecheck、bun test、以及qmd --help的 smoke 检查。 - 失败时会在指定 issue(默认 #25)上创建或更新一条带 marker 的告警评论。
Blocking:
- None
Suggestions:
- 可选:
Remote-only constraint目前只扫描src/和package.json;仓库内仍有.github/workflows/release.yml中node-llama-cpp相关字样。若 PR 目标是“彻底移除本地 LLM 痕迹”,可考虑把检查范围扩展到工作流/脚本目录,或明确声明这些残留是允许的构建参数。 - 可选:
grep规则是纯字符串匹配,后续可能出现注释/文档文字触发误报;可考虑增加白名单路径或更精确匹配策略以降低噪音。
There was a problem hiding this comment.
VERDICT: APPROVE
Summary:
- 新增了
Repo Healthcheck的 GitHub Actions 定时/手动工作流,并统一了执行环境(checkout、bun、系统依赖、安装依赖)。 - 在 CI 中增加了远程模式约束检查:扫描
src/和package.json,阻止本地 LLM 相关引用(node-llama-cpp/ollama等)。 - 加入了基础质量门禁(
typecheck、bun test、qmd --helpsmoke)以及失败时自动回写 issue 评论的机制。
Blocking:
- None
Suggestions:
Remote-only constraint (src)里的grep建议增加目录白名单/黑名单(例如排除dist/、生成文件、fixture),减少误报导致的维护成本。ISSUE_NUMBER的输入可增加简单校验(非正整数时回退默认值),避免手动触发时传入异常值导致评论步骤报错(虽已continue-on-error)。CLI smoke当前只覆盖qmd --help;可按需补充qmd status/search/query中至少一个无副作用子命令,提升对运行时回归的捕获率。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
由 Codex CLI (gpt-5.2) 自动生成
对应 Issue #25
Closes #25