Test --use-system-libraries option in Travis CI #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I have doubled the number of build jobs so that this option is tested against every Ruby. However, if it's a problem, I can reduce it to a single additional job, e.g: |
Actually, $RUBY_GPGME_USE_SYSTEM_LIBRARIES environment variable is tested, but it is equivalent.
skalee
force-pushed
the
test-with-system-libs
branch
from
16a6e5a to
aa7722d
Compare
|
Tests have failed for all Travis jobs which are testing Possibly all these errors/failures have single reason. I have investigated one of them: A failing test looks as follows: it "selects who to sign for" do
crypto = GPGME::Crypto.new
sign = crypto.sign "Hi there", :signer => KEYS.last[:sha]
key = GPGME::Key.get(KEYS.last[:sha]) # <= FAILS HERE
# ...
endThe KEYS.map { |k| k[:sha] }
# => ["[email protected]", "[email protected]", "[email protected]", "[email protected]"]However, the last key is unavailable in GPGME for some reason: GPGME::Key.find(:public).flat_map(&:uids)
# => [#<GPGME::UserID Test number 1 <[email protected]> validity=unknown, signatures=[]>, #<GPGME::UserID Test number 2 <[email protected]> validity=unknown, signatures=[]>, #<GPGME::UserID Test number 3 <[email protected]> validity=unknown, signatures=[]>]
GPGME::Key.find(:secret).flat_map(&:uids)
# => [#<GPGME::UserID Test number 1 <[email protected]> validity=unknown, signatures=[]>, #<GPGME::UserID Test number 2 <[email protected]> validity=unknown, signatures=[]>, #<GPGME::UserID Test number 3 <[email protected]> validity=unknown, signatures=[]>]Interestingly, when I tried to import that missing key by hand, it has been added: GPGME::Key.import(KEYS.last[:public])
GPGME::Key.find(:public).flat_map(&:uids)
# => [#<GPGME::UserID Test number 1 <[email protected]> validity=unknown, signatures=[]>, #<GPGME::UserID Test number 2 <[email protected]> validity=unknown, signatures=[]>, #<GPGME::UserID Test number 3 <[email protected]> validity=unknown, signatures=[]>, #<GPGME::UserID Test number 4 <[email protected]> validity=unknown, signatures=[]>]
GPGME::Key.get(KEYS.last[:sha]) # <= NO ERROR!Some race condition, perhaps? (EDIT: Adding |
stanhu
added a commit
to stanhu/ruby-gpgme
that referenced
this pull request
Aug 28, 2024
Relates to ueno#128
stanhu
added a commit
to stanhu/ruby-gpgme
that referenced
this pull request
Aug 28, 2024
Relates to ueno#128
stanhu
added a commit
to stanhu/ruby-gpgme
that referenced
this pull request
Aug 28, 2024
Relates to ueno#128
|
Closing in favor of #191. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gem can be installed with a
--use-system-librariesoption, but till now it wasn't tested. This pull request fixes that.Actually,
$RUBY_GPGME_USE_SYSTEM_LIBRARIESenvironment variable is used instead of--use-system-libraries, but they are equivalent.