Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose gpgme_data_set_file_name #101

Merged
merged 1 commit into from
Dec 24, 2017
Merged

Conversation

iwat
Copy link
Contributor

@iwat iwat commented Oct 5, 2017

When using gpg -dv <filename> to decrypt a file, it displays "original file name" that shows the name of the original file before encrypting. But when encrypting from GPGME::Data stream, the file name was lost. And gpg displays "-&20" or similar string as the original file name.

This commit adds the ability to set the file_name property of GPGME::Data object, this property will be displayed as "original file name" when decrypting with gpg -dv command.

This solves #99

@coveralls
Copy link

coveralls commented Oct 5, 2017

Coverage Status

Coverage decreased (-1.8%) to 90.518% when pulling 13111b5 on iwat:expose_data_set_file_name into a261dc9 on ueno:master.

@ueno
Copy link
Owner

ueno commented Oct 5, 2017

Thank you, that's great. Although the CI is failing, I don't think it's caused by this change.

When using `gpg -dv <filename>` to decrypt a file, it displays "original
file name" that shows the name of the original file before encrypting.
But when encrypting from GPGME::Data stream, the file name was lost. And
gpg displays "-&20" or similar string as the original file name.

This commit adds the ability to set the `file_name` property of
GPGME::Data object, this property will be displayed as "original file
name" when decrypting with `gpg -dv` command.
@iwat iwat force-pushed the expose_data_set_file_name branch from 13111b5 to bd6aac4 Compare November 21, 2017 05:50
@coveralls
Copy link

coveralls commented Nov 21, 2017

Coverage Status

Coverage increased (+0.1%) to 90.544% when pulling bd6aac4 on iwat:expose_data_set_file_name into f70d026 on ueno:master.

@ueno ueno merged commit b7f30a0 into ueno:master Dec 24, 2017
@iwat iwat deleted the expose_data_set_file_name branch December 25, 2017 04:32
dansketcher added a commit that referenced this pull request Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants