Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use prettier for linting #5796

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

build: use prettier for linting #5796

wants to merge 2 commits into from

Conversation

nperez0111
Copy link
Contributor

Changes Overview

It has been annoying that there isn't prettier styles in this repo

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

changeset-bot bot commented Nov 1, 2024

⚠️ No Changeset found

Latest commit: eee0e83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 55 packages
Name Type
@tiptap/extension-list-keymap Major
@tiptap/core Major
@tiptap/vue-3 Major
@tiptap/extension-bubble-menu Major
@tiptap/vue-2 Major
@tiptap/react Major
@tiptap/extension-mention Major
@tiptap/extension-hard-break Major
@tiptap/extension-table Major
@tiptap/extension-link Major
tiptap-demos Patch
@tiptap/extension-blockquote Major
@tiptap/extension-bold Major
@tiptap/extension-bullet-list Major
@tiptap/extension-character-count Major
@tiptap/extension-code-block-lowlight Major
@tiptap/extension-code-block Major
@tiptap/extension-code Major
@tiptap/extension-collaboration-cursor Major
@tiptap/extension-collaboration Major
@tiptap/extension-color Major
@tiptap/extension-document Major
@tiptap/extension-dropcursor Major
@tiptap/extension-floating-menu Major
@tiptap/extension-focus Major
@tiptap/extension-font-family Major
@tiptap/extension-gapcursor Major
@tiptap/extension-heading Major
@tiptap/extension-highlight Major
@tiptap/extension-history Major
@tiptap/extension-horizontal-rule Major
@tiptap/extension-image Major
@tiptap/extension-italic Major
@tiptap/extension-list-item Major
@tiptap/extension-ordered-list Major
@tiptap/extension-paragraph Major
@tiptap/extension-placeholder Major
@tiptap/extension-strike Major
@tiptap/extension-subscript Major
@tiptap/extension-superscript Major
@tiptap/extension-table-cell Major
@tiptap/extension-table-header Major
@tiptap/extension-table-row Major
@tiptap/extension-task-item Major
@tiptap/extension-task-list Major
@tiptap/extension-text-align Major
@tiptap/extension-text-style Major
@tiptap/extension-text Major
@tiptap/extension-typography Major
@tiptap/extension-underline Major
@tiptap/extension-youtube Major
@tiptap/html Major
@tiptap/pm Major
@tiptap/starter-kit Major
@tiptap/suggestion Major

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit eee0e83
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/673213d2bb10a500078de32c
😎 Deploy Preview https://deploy-preview-5796--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdbch
Copy link
Member

bdbch commented Dec 2, 2024

Should the base change be rather applied to main/develop and formatting be done on that said branch rather than doing it on next?

@nperez0111
Copy link
Contributor Author

Should the base change be rather applied to main/develop and formatting be done on that said branch rather than doing it on next?

I didn't do it on develop because I did not want to force everyone who has open PRs to have to update their PRs just for a lint rule. So I figured it was okay to just apply to next only. But, I can go either way on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants