Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension-highlight): add paste rule #5527

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Gregoor
Copy link

@Gregoor Gregoor commented Aug 20, 2024

Changes Overview

This parses out highlight color when pasting

Implementation Approach

I use DOMParser to look at the clipboard, find span's with non-default bg color and use it for the highlight mark.

I use a running counter (indexAcc) to keep track where I am in the clipboard text, as DOMParser does not come with source maps. Unfortunately I couldn't get that to work with paragraphs in the time that I had, so I just skip them when they are present.

Testing Done

None added yet, happy to do so if desired

Verification Steps

npm dev => http://localhost:3000/preview/Marks/Highlight => paste some bg highlighted text from Docs/Word/Pages/...

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

#5476

Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: 55fb1ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 55fb1ab
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66c4c7f80c64b30008aa5521
😎 Deploy Preview https://deploy-preview-5527--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gregoor
Copy link
Author

Gregoor commented Oct 1, 2024

I know this isn't great yet, @bdbch do you have some guidance for me on how I could make this adequate and mergeable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Triage open
Development

Successfully merging this pull request may close these issues.

1 participant