Skip to content

Eliminate warnings in modern Elixir releases #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
am-kantox wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Eliminate warnings in modern Elixir releases #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16defcf
⇑ Remove warnings in 1.19
am-kantox Aug 20, 2025
f69d486
Make `:preferred_cli_env`/`def cli` optional based on version
am-kantox Aug 20, 2025
51c31c1
Make `:preferred_cli_env`/`def cli` optional based on version
am-kantox Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/oauth2/client.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ defmodule OAuth2.Client do
@spec put_serializer(t, binary, atom) :: t
def put_serializer(%Client{serializers: serializers} = client, mime, module)
when is_binary(mime) and is_atom(module) do
%Client{client | serializers: Map.put(serializers, mime, module)}
%{client | serializers: Map.put(serializers, mime, module)}
end

@doc """
Expand All @@ -238,7 +238,7 @@ defmodule OAuth2.Client do
"""
@spec delete_serializer(t, binary) :: t
def delete_serializer(%Client{serializers: serializers} = client, mime) do
%Client{client | serializers: Map.delete(serializers, mime)}
%{client | serializers: Map.delete(serializers, mime)}
end

@doc false
Expand Down
35 changes: 28 additions & 7 deletions mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,20 @@ defmodule OAuth2.Mixfile do
@version "2.1.0"

def project do
maybe_cli =
if Version.compare(System.version(), "1.14.5") == :gt do
[]
else
[
preferred_cli_env: [
coveralls: :test,
"coveralls.detail": :test,
"coveralls.html": :test,
docs: :dev
]
]
end

[
app: :oauth2,
name: "OAuth2",
Expand All @@ -16,14 +30,8 @@ defmodule OAuth2.Mixfile do
docs: docs(),
elixirc_paths: elixirc_paths(Mix.env()),
test_coverage: [tool: ExCoveralls],
preferred_cli_env: [
coveralls: :test,
"coveralls.detail": :test,
"coveralls.html": :test,
docs: :dev
],
dialyzer: dialyzer()
]
] ++ maybe_cli
end

def application do
Expand Down Expand Up @@ -81,6 +89,19 @@ defmodule OAuth2.Mixfile do
]
end

if Version.compare(System.version(), "1.14.5") == :gt do
def cli do
[
preferred_envs: [
coveralls: :test,
"coveralls.detail": :test,
"coveralls.html": :test,
docs: :dev
]
]
end
end

defp elixirc_paths(:test), do: ["lib", "test/support"]
defp elixirc_paths(_), do: ["lib"]
end