Skip to content

Add error, link error, panel lock and initialized attributes for devices #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions maxcube/cube.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,16 +232,19 @@ def parse_l_message(self, message):
device_rf_address = self.parse_rf_address(data[pos + 1 : pos + 4])

device = self.device_by_rf(device_rf_address)
bits1, bits2 = struct.unpack("BB", bytearray(data[pos + 5 : pos + 7]))

if device:
bits1, bits2 = struct.unpack("BB", bytearray(data[pos + 5 : pos + 7]))
device.battery = self.resolve_device_battery(bits2)
device.link_error = self.resolve_device_link_error(bits2)
device.initialized = self.resolve_device_initialized(bits1)
device.error = self.resolve_device_error(bits1)

# Thermostat or Wall Thermostat
if device and (device.is_thermostat() or device.is_wallthermostat()):
device.target_temperature = (data[pos + 8] & 0x7F) / 2.0
bits1, bits2 = struct.unpack("BB", bytearray(data[pos + 5 : pos + 7]))
device.mode = self.resolve_device_mode(bits2)
device.panel_locked = self.resolve_device_panel_locked(bits2)

# Thermostat
if device and device.is_thermostat():
Expand Down Expand Up @@ -365,10 +368,26 @@ def set_programmes_from_config(self, config_file):
def resolve_device_mode(cls, bits):
return bits & 3

@classmethod
def resolve_device_panel_locked(cls, bits):
return 1 if bits & 0b00100000 else 0

@classmethod
def resolve_device_link_error(cls, bits):
return 1 if bits & 0b01000000 else 0

@classmethod
def resolve_device_battery(cls, bits):
return bits >> 7

@classmethod
def resolve_device_initialized(cls, bits):
return 1 if bits & 0b00000010 else 0

@classmethod
def resolve_device_error(cls, bits):
return 1 if bits & 0b00001000 else 0

@classmethod
def parse_rf_address(cls, address):
return "".join("{:02X}".format(x) for x in address)
Expand Down
24 changes: 24 additions & 0 deletions maxcube/device.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,18 @@
MAX_DEVICE_BATTERY_OK = 0
MAX_DEVICE_BATTERY_LOW = 1

MAX_DEVICE_PANEL_UNLOCKED = 0
MAX_DEVICE_PANEL_LOCKED = 1

MAX_DEVICE_LINK_STATUS_OK = 0
MAX_DEVICE_LINK_STATUS_ERROR = 1

MAX_DEVICE_STATUS_NOT_INITIALIZED = 0
MAX_DEVICE_STATUS_INITIALIZED = 1

MAX_DEVICE_ERROR_NO = 0
MAX_DEVICE_ERROR_YES = 1

MODE_NAMES = {
MAX_DEVICE_MODE_AUTOMATIC: "auto",
MAX_DEVICE_MODE_MANUAL: "manual",
Expand All @@ -30,6 +42,10 @@ def __init__(self):
self.room_id = None
self.name = None
self.serial = None
self.panel_locked = None
self.link_status = None
self.status_inited = None
self.error = None
self.battery = None
self.programme = None

Expand All @@ -49,6 +65,14 @@ def describe(self, kind: str, *args: Tuple[str]):
state = "".join("," + s for s in args if s)
if self.battery == MAX_DEVICE_BATTERY_LOW:
state = ",LOW_BATT" + state
if self.error == MAX_DEVICE_ERROR_YES:
state = ",ERROR" + state
if self.link_status == MAX_DEVICE_LINK_STATUS_ERROR:
state = ",LINK_ERROR" + state
if self.panel_locked == MAX_DEVICE_PANEL_LOCKED:
state = ",LOCKED" + state
if self.status_inited == MAX_DEVICE_STATUS_NOT_INITIALIZED:
state = ",NOT_INITIALIZED" + state
return f"{kind} sn={self.serial},rf={self.rf_address},name={self.name}" + state

def __str__(self):
Expand Down