Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forum channel to addcourse command #338

Open
wants to merge 2 commits into
base: dev-fixes
Choose a base branch
from
Open

Add forum channel to addcourse command #338

wants to merge 2 commits into from

Conversation

leo-cx
Copy link
Contributor

@leo-cx leo-cx commented May 30, 2024

Addressing issue #334

@leo-cx leo-cx requested review from sbrugel, bladetyr and mattnadar May 30, 2024 19:54
@leo-cx leo-cx self-assigned this May 30, 2024
bladetyr
bladetyr approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@bladetyr bladetyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, don't forget the tempdev thing I said in the Discord ^^

@sbrugel
Copy link
Contributor

sbrugel commented Jun 10, 2024

When you can, could you switch the branch from main to dev-fix? We can merge to main from there when the time comes.

@leo-cx leo-cx changed the base branch from main to dev-fixes June 11, 2024 07:50
@leo-cx
Copy link
Contributor Author

leo-cx commented Jun 11, 2024

Aye aye, branch set to dev-fixes and accompanying conflict is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bladetyr bladetyr bladetyr approved these changes

@sbrugel sbrugel Awaiting requested review from sbrugel

@mattnadar mattnadar Awaiting requested review from mattnadar

Assignees

@leo-cx leo-cx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leo-cx @sbrugel @bladetyr