Skip to content

Phadej ghc 8.4 #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 394 commits into from
Oct 9, 2018
Merged

Phadej ghc 8.4 #1353

merged 394 commits into from
Oct 9, 2018

Conversation

ranjitjhala
Copy link
Member

@ranjitjhala ranjitjhala commented Aug 2, 2018

This PR moves LH to GHC 8.4 (thanks to @phadej -- cf #1330)

However, it is also a significant refactor of Bare, specifically, deleting BareM and all the inscrutable global dependencies that it wrought.

Not ready to merge yet.

  • asserted-sigs
  • unqualified imports
  • assumed-sigs
  • alias
  • importing
  • measures
  • importing
  • invariants
  • importing
  • holes
  • reflect / PLE
  • importing
  • datacon
  • importing
  • class/instance measures (len)
  • absref
  • class-refinements
  • lifted-bounds
  • termination
  • auto-size
  • source-spans
  • error-messages

Current Score (9/12/2018)

Only the following tests fail:

Fixpoint-apply-unknown-sort

  • tests/todo-rebare/T1089b.hs [RJ]

Mystery

  • tests/todo-rebare/DataKinds.hs [NV]

CLASS

  • tests/todo-rebare/NatClass.hs [NV]
  • tests/todo-rebare/VerifiedMonoid_NEG.hs [NV]
  • tests/todo-rebare/VerifiedMonoid_POS.hs [NV]
  • tests/classes/neg/Inst01.hs [NV]

@ranjitjhala
Copy link
Member Author

Current score no-bench and no-error

Fri Aug 17 02:30:45 PDT 2018

rjhala@goto ~/r/s/l/liquidhaskell (phadej-ghc-8.4)> ack "OK" nohup.out  | wc
    862    2588   40670
rjhala@goto ~/r/s/l/liquidhaskell (phadej-ghc-8.4)> ack "FAIL" nohup.out  | wc
    177     540    8719

@ranjitjhala
Copy link
Member Author

@nikivazou this is very close to merging.

I am going to remove the billion tracepp

scattered all over and then merge.

Better try it against your benchmarks soon :-)

@phadej
Copy link
Contributor

phadej commented Oct 9, 2018

@ranjitjhala FWIW, the dependencies are slowly but steadily catching up with GHC-8.6.1, so I might make another PR(s) after this is merged. (I'd probably wait for GHC-8.6.2 to come out first)

@ranjitjhala
Copy link
Member Author

@phadej that would be great! Since stuff is relatively fresh in my mind, it should be possible to make that upgrade soon too!

@ranjitjhala ranjitjhala merged commit 3f21e54 into develop Oct 9, 2018
@ranjitjhala
Copy link
Member Author

Here goes!

@nikivazou nikivazou deleted the phadej-ghc-8.4 branch June 10, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants