Skip to content

Conversation

@nimakarimipour
Copy link
Member

This PR is built upon #95

This PR resolves #97 by adding informative comment on @NullUnmarked injections.

Each comment has the format below:

// local for errors within the scope of the annotation, //non-local for errors outside annotation scope but within the same module, and //dependent module for errors in dependent modules.

To activate comment generation on NullUnmarked injection, flag acg must be passed to Annotator. We can also add a prefix to all generated comments via flag: cprefix.

-acg, --acitave-comment-generation
-cprefix, --comment-prefix (optional)

Or via passing a json file.

"COMMENT": {
     "ACTIVATION": true,
     "PREFIX": "prefix"
}

@nimakarimipour nimakarimipour self-assigned this Nov 20, 2022
@nimakarimipour nimakarimipour linked an issue Nov 20, 2022 that may be closed by this pull request
@nimakarimipour nimakarimipour added the enhancement New feature or request label Jan 2, 2023
@nimakarimipour
Copy link
Member Author

@msridhar @lazaroclapp I am converting this to draft for now, will get back to it if we wanted to have this feature.

@nimakarimipour nimakarimipour marked this pull request as draft February 6, 2023 02:47
@nimakarimipour
Copy link
Member Author

@msridhar @lazaroclapp I am closing this one as I don't think we have any plans for now to bring this feature back. Also the branch is too old to revive. Please let me know if you would like to discuss this further, thank you.

@nimakarimipour nimakarimipour deleted the nimak/issue-91 branch February 24, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add informative comment on @NullUnmarked injections

2 participants