Use visitor for applying changes with locations #171
Conversation
| * @return the modification that should be applied. | ||
| */ | ||
| @Nullable | ||
| public Modification visit(Change change) { |
There was a problem hiding this comment.
It is confusing to name this method visit since it's not one of the standard visitor methods. How about:
| public Modification visit(Change change) { | |
| public Modification computeModification(Change change) { |
| } | ||
|
|
||
| /** | ||
| * Applies the change to the compilation unit. |
There was a problem hiding this comment.
This doesn't actually apply any change, right? It just computes the change (Modification) to be applied?
There was a problem hiding this comment.
Yes exactly. I reworded the java doc to mention this, please let me know if I should update it. 2e2dd6b
There was a problem hiding this comment.
Hrm, I don't see the javadoc changes here; maybe the commit got lost somehow?
There was a problem hiding this comment.
Sorry for that, the change was on the javadoc for the class. Update the method javadoc as well 66edb7e
| } | ||
|
|
||
| /** | ||
| * Applies the change to the compilation unit. |
There was a problem hiding this comment.
Hrm, I don't see the javadoc changes here; maybe the commit got lost somehow?
This PR updates the logic for applying changes specified by
Locationinstances using the visitor pattern architecture added in #169