Skip to content

Avoid serializing 0-argument super calls in constructors #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nimakarimipour wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Avoid serializing 0-argument super calls in constructors #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d73b07e
update scanner for serializing constructors
nimakarimipour Feb 16, 2023
7a3520e
add comment
nimakarimipour Feb 16, 2023
dd8b6e9
update
nimakarimipour Feb 16, 2023
7708957
add comment
nimakarimipour Feb 16, 2023
3651815
merge master
nimakarimipour Feb 17, 2023
3cbb086
update unit test
nimakarimipour Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions annotator-scanner/src/main/java/edu/ucr/cs/riple/scanner/AnnotatorScanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,14 @@ public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState
if (!config.callTrackerIsActive()) {
return Description.NO_MATCH;
}
Symbol.MethodSymbol calledMethod = ASTHelpers.getSymbol(tree);
if (calledMethod != null
&& calledMethod.isConstructor()
&& calledMethod.getParameters().size() == 0) {
// to avoid serializing the default generated constructors. They cannot have any impact on the
// region.
return Description.NO_MATCH;
}
config
.getSerializer()
.serializeImpactedRegionForMethod(
Expand Down
32 changes: 21 additions & 11 deletions annotator-scanner/src/test/java/edu/ucr/cs/riple/scanner/MethodImpactedRegionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,20 +83,30 @@ public void constructorCallTest() {
"edu/ucr/A.java",
"package edu.ucr;",
"public class A {",
" Object b;",
" A(Object b) {",
" this.b = b;",
" A a = new A();",
" A b = new A(0);",
" A() { }",
" A(int i) { }",
" void bar() {",
" A a = new A();",
" }",
"}")
.addSourceLines(
"edu/ucr/B.java",
"package edu.ucr;",
"public class B extends A {",
" B b = new B();",
" B() { }",
" void run() {",
" A a = new A();",
" }",
"}",
"class B {",
" void run() {",
" A a = new A(null);",
" }",
"}")
.setExpectedOutputs(
new TrackerNodeDisplay("edu.ucr.B", "run()", "edu.ucr.A", "A(java.lang.Object)"),
new TrackerNodeDisplay(
"edu.ucr.A", "A(java.lang.Object)", "java.lang.Object", "Object()"))
new TrackerNodeDisplay("edu.ucr.A", "a", "edu.ucr.A", "A()"),
new TrackerNodeDisplay("edu.ucr.A", "b", "edu.ucr.A", "A(int)"),
new TrackerNodeDisplay("edu.ucr.A", "bar()", "edu.ucr.A", "A()"),
new TrackerNodeDisplay("edu.ucr.B", "run()", "edu.ucr.A", "A()"),
new TrackerNodeDisplay("edu.ucr.B", "b", "edu.ucr.B", "B()"))
.doTest();
}

Expand Down