Skip to content

Libscholar 46 update home page #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haitzlm merged 8 commits into from
Mar 24, 2026
Merged

Libscholar 46 update home page #1190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
559a0d7
Update home page: remove external links, move Manage Your Data to Hel…
Janell-Huyck Dec 1, 2025
6f3e13b
Disable flaky collection delete feature spec in CI
Janell-Huyck Dec 1, 2025
941500c
Update specs: remove external links test from homepage, add Manage Yo…
Janell-Huyck Dec 1, 2025
83b8201
Update IT@UC partner icon to DTS@UC logo
Janell-Huyck Dec 2, 2025
aafcf71
Merge branch 'develop' into LIBSCHOLAR-46-update-home-page
Janell-Huyck Mar 23, 2026
4ba20ce
Update bundler-audit.yml
Janell-Huyck Mar 23, 2026
e173c49
Apply suggestion from @Copilot
haitzlm Mar 24, 2026
ba28c15
Merge branch 'develop' into LIBSCHOLAR-46-update-home-page
Janell-Huyck Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added app/assets/images/dts_uc.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed app/assets/images/ituc.png
View file
Open in desktop
Binary file not shown.
2 changes: 0 additions & 2 deletions app/views/hyrax/homepage/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,5 @@

<%= render '/shared/select_work_type_modal', create_work_presenter: @presenter.create_work_presenter if @presenter.draw_select_work_modal? %>

<%= render 'layouts/scholar/links' %>

<%= render 'layouts/scholar/partner_headline' %>
<%= render 'layouts/scholar/partner_branding' %>
5 changes: 0 additions & 5 deletions app/views/layouts/scholar/_links.html.erb
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions app/views/layouts/scholar/_partner_branding.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
<% end %>
</div>

<div class="col-sm-3 col-xs-6 itatuc">
<%= link_to 'http://ucit.uc.edu', target: '_blank' do %>
<%= image_tag("ituc.png", class: 'img-responsive') %>
<div class="col-sm-3 col-xs-6 dts-uc">
<%= link_to 'https://www.uc.edu/about/ucit.html', target: '_blank' do %>
<%= image_tag("dts_uc.png", class: 'img-responsive') %>
Comment on lines +16 to +17
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updated partner link still uses target: '_blank' without rel="noopener noreferrer", which can expose users to reverse-tabnabbing. Add a rel attribute when opening external sites in a new tab.

Copilot uses AI. Check for mistakes.
<% end %>
</div>

Expand Down
3 changes: 3 additions & 0 deletions app/views/static/help.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
<dt><%= link_to 'File Format Advice', format_advice_path %></dt>
<dd>How to choose the best file formats for your content</dd>

<dt><%= link_to t('hyrax.homepage.links.manage_your_data'), "http://guides.libraries.uc.edu/datamanagementplanning", target: '_blank' %></dt>
<dd>Resources for managing your research data</dd>
Comment on lines +25 to +26
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new external link opens in a new tab (target: '_blank') but does not set rel="noopener noreferrer", which can allow reverse-tabnabbing. Add an appropriate rel value for this link (and any other _blank links you touch here).

Copilot uses AI. Check for mistakes.

<dt><%= link_to "Student Works", student_work_help_path %></dt>
<dd>Help for students wanting to add content to <%=t('hyrax.product_name') %></dd>

Expand Down
4 changes: 2 additions & 2 deletions spec/features/hyrax/dashboard/collection_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,9 +432,9 @@ def get_url_fragment(type)
end

context 'and collection is not empty' do
# Disabled due to flakiness in CI (intermittent failures around the collection delete modal).
# Disabled due to flakiness in CI when interacting with the collection delete modal.
# Re-enable once the underlying Capybara/JS timing issues are resolved.
xit it 'and user confirms delete, deletes the collection', :js do
xit 'and user confirms delete, deletes the collection', :js do
within("table#collections-list-table") do
expect(page).to have_content(collection.title.first)
end
Expand Down
5 changes: 0 additions & 5 deletions spec/features/hyrax/homepage_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,6 @@
expect(page).to have_css('div.scholar-home-tag.text-center')
end

it 'shows external links' do
visit root_path
expect(page).to have_css('div.ext-links.text-center')
end

it 'shows partners' do
visit root_path
expect(page).to have_css('div.partner-branding.row')
Expand Down
4 changes: 4 additions & 0 deletions spec/views/static/help.html.erb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,8 @@
expect(rendered).to have_link(href: student_work_help_path)
expect(rendered).to have_link(href: welcome_page_index_path)
end

it 'has the Manage Your Data link' do
expect(rendered).to have_link('Manage Your Data', href: 'http://guides.libraries.uc.edu/datamanagementplanning')
end
end
Loading