Whitelist hierarchy request field list [arclight]#1175
Open
amywieliczka wants to merge 1 commit intomainfrom
Open
Whitelist hierarchy request field list [arclight]#1175amywieliczka wants to merge 1 commit intomainfrom
amywieliczka wants to merge 1 commit intomainfrom
Conversation
bibliotechy
approved these changes
Feb 13, 2026
Contributor
|
@amywieliczka I gthink the test in this case would be less about the speed, than about ensuring the it still rebnders the expected content. Which will be useful if in the future we want to change this again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not totally sure how to test this, especially since it seems these hierarchy queries are particularly slow on production but not on stage?
Maybe I time curl
https://oac.cdlib.org/findaid/<ark>/hierarchy?hierarchy=truefor the finding aids with the most children, and then deploy this change and see if it has any effect?