feat(solver): significantly improve solver performance #103
Conversation
perf(Solver): further improvements to solver
rohanku
left a comment
rohanku
left a comment
There was a problem hiding this comment.
Left some basic comments, will need to take a more careful look at your unsafe code/null space logic.
.gitignore
Outdated
| *.tsbuildinfo | ||
|
|
||
| # Ignore timing files | ||
| *.txt |
There was a problem hiding this comment.
Don't want to exclude all txt files since they are sometimes useful (e.g. requirements.txt for Python), you can make your timing files have a .log suffix and exclude that.
Cargo.toml
Outdated
| geometry = { version = "0.7", registry = "substrate" } | ||
| enumify = { version = "0.2", registry = "substrate" } | ||
|
|
||
| [profile.release] |
There was a problem hiding this comment.
Remove this, don't want release to always be in debug mode.
core/compiler/.gitignore
Outdated
| build/ | ||
|
|
||
| # Ignore timing files | ||
| *.txt |
| [dependencies] | ||
| derive-where = { version = "1", features = ["serde"] } | ||
| nalgebra = "0.34" | ||
| nalgebra = { version = "0.34", features = ["rayon"] } |
There was a problem hiding this comment.
Run cargo-udeps to make sure all these dependencies are being used.
core/compiler/Cargo.toml
Outdated
|
|
||
| [build-dependencies] | ||
| lrpar = { version = "0.13", features = ["serde"] } | ||
| #trying sparse |
core/compiler/src/solver.rs
Outdated
| { | ||
| let val = round(sol[(i as usize, 0)]); | ||
| self.solved_vars.insert(Var(i), val); | ||
| let mut var_map = vec![usize::MAX; n_vars]; //og matrix -> shrunk matrix |
core/compiler/src/solver.rs
Outdated
| use std::fs::OpenOptions; | ||
| use std::io::Write; | ||
|
|
||
| let time_str = format!( |
There was a problem hiding this comment.
Remove this or use tracing to log things (use the trace! macro).
core/compiler/src/solver.rs
Outdated
| }); | ||
| solver.solve(); | ||
| assert_relative_eq!(*solver.solved_vars.get(&x).unwrap(), 5., epsilon = EPSILON); | ||
| assert_relative_eq!(*solver.solved_vars.get(&y).unwrap(), 5., epsilon = EPSILON); |
flamegraph.svg
Outdated
package-lock.json
Outdated
There was a problem hiding this comment.
What editor are you using? Seems like it's adding new lines to everything.
There was a problem hiding this comment.
Can you write some unit tests for the solver? We don't do any solver correctness checks in our "integration" tests.
No description provided.