-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow nullable expiry per 0.9.0 spec. Fixes #23 #95
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 57.10% 57.26% +0.15%
==========================================
Files 24 24
Lines 802 805 +3
Branches 196 197 +1
==========================================
+ Hits 458 461 +3
Misses 206 206
Partials 138 138
|
ade9916
to
e4d0f76
Compare
Updated to not encode expiry if empty per canonicalization |
e4d0f76
to
45d324e
Compare
Stepping back from this. The |
51a934b
to
382219a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a request for some coverage 🙏
382219a
to
cda9d76
Compare
Broke out tests into two: one for serialization without optionals (covers and clarifies these collection of PRs with optionality changes), and one specifically for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.