Skip to content

Fix empty output files bug - #183

Merged
paulineribeyre merged 8 commits into
masterfrom
debug-empty-output
Aug 14, 2026
Merged

Fix empty output files bug#183
paulineribeyre merged 8 commits into
masterfrom
debug-empty-output

Conversation

@paulineribeyre

Copy link
Copy Markdown
Collaborator

Link to JIRA ticket if there is one:

New Features

Breaking Changes

Bug Fixes

  • Fix bug: empty output files when downloaded by Nextflow (through the AWS SDK for Java)

Improvements

Dependency updates

Deployment changes

@github-actions

Copy link
Copy Markdown

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 31829493650

Coverage decreased (-0.4%) to 84.274%

Details

  • Coverage decreased (-0.4%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 29 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

29 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
routes/s3.py 29 74.88%

Coverage Stats

Coverage Status
Relevant Lines: 1170
Covered Lines: 986
Line Coverage: 84.27%
Coverage Strength: 0.84 hits per line

💛 - Coveralls

@george42-ctds george42-ctds left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions

Copy link
Copy Markdown

Integration Tests on Kind

filepath passed skipped SUBTOTAL
tests/test_gen3_workflow.py 28 2 30
TOTAL 28 2 30

@github-actions

Copy link
Copy Markdown

Integration Tests

Test summary after running integration tests

filepath passed failed skipped SUBTOTAL
tests/test_gen3_workflow.py 28 1 1 30
TOTAL 28 1 1 30

Test summary after rerunning failed integration tests

filepath passed SUBTOTAL
tests/test_gen3_workflow.py 1 1
TOTAL 1 1

Please find the detailed integration test report here

Please find the detailed integration test report after rerunning failed tests here

Please find the Github Action logs here

@paulineribeyre
paulineribeyre merged commit 3cc65d4 into master Aug 14, 2026
12 checks passed
@paulineribeyre
paulineribeyre deleted the debug-empty-output branch August 14, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants