Fix "x-amz-server-side-encryption header is not supported for this operation" errors - #181
Merged
Merged
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
paulineribeyre
commented
Aug 10, 2026
| # The deny in this policy fires when the headers are present but wrong (e.g. trying not to use | ||
| # KMS encryption, or trying to use a different KMS key). If the headers are absent, the request | ||
| # is accepted and AWS falls back on the bucket's default encryption (set above). | ||
| # TODO: stop specifying the KMS key in the funnel config |
Collaborator
Author
There was a problem hiding this comment.
^ doing this TODO fixed the issue
Integration Tests on Kind
|
| async def _create_user_bucket(user_id: str) -> Tuple[str, str]: | ||
| async def _create_user_bucket(user_id: str) -> str: | ||
| """ | ||
| Create an S3 bucket for the specified user and return information about the bucket. |
There was a problem hiding this comment.
Maybe update the docstring to show that only bucket_name is returned.
Coverage Report for CI Build 31427948910Coverage decreased (-0.2%) to 84.655%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions55 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
Integration Tests on Kind
|
Integration TestsTest summary after running integration tests
Test summary after rerunning failed integration tests
Please find the detailed integration test report here Please find the detailed integration test report after rerunning failed tests here Please find the Github Action logs here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adressing this error (Slack thread):
This seems to happen during multipart uploads.
The incoming file upload request from the Funnel worker already includes the
x-amz-server-side-encryptionheader - it's not added by gen3-workflowRemoving the KMS Key from Funnel’s GenericS3 config (set by the Funnel plugin) fixes the issue: KMS encryption is now managed automatically by this policy.
This means we can remove the KMS key ARN from the
/storage/setupendpoint response. Doing this was a TODO anyway.Depends on uc-cdis/funnel-gen3-plugin#15 and may fail integration tests until it's merged
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
x-amz-server-side-encryption header is not supported for this operationerrors during some multipart uploadsImprovements
Dependency updates
Deployment changes