Skip to content

fix(folders): more than one per PR #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbarno wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(folders): more than one per PR #608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions gen3-integration-tests/gen3_ci/scripts/prepare_ci_environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,14 +244,11 @@ def prepare_ci_environment(namespace):
with open(os.getenv("GITHUB_ENV"), "a") as f:
f.write("SKIP_TESTS=true\n")
return
elif len(updated_folders) > 1:
# Raise Error if more than 1 folder is updated per PR
raise Exception(
"More than 1 folder updated, please update only 1 folder per PR..."
)
logger.info(f"Setting up env using folder: {updated_folder}")
result = modify_env_for_manifest_pr(namespace, updated_folder, repo)
assert result.lower() == "success"
for i in range(len(updated_folders)):
folder = updated_folder[i]

@krishnaa05 krishnaa05 Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this would result in setting up the env multiple times with each manifest folder. I dont think we should be modifying this logic

logger.info(f"Setting up env using folder: {folder}")
result = modify_env_for_manifest_pr(namespace, folder, repo)
assert result.lower() == "success"
else: # Service repos
quay_tag = (
os.getenv("BRANCH").replace("(", "_").replace(")", "_").replace("/", "_")
Expand Down
Loading