Skip to content

Add drs tests for space url cases #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
k-burt-uch wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add drs tests for space url cases #497

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fb3c34
Add drs tests for space url cases
k-burt-uch Mar 13, 2026
575f7e1
Refactor DRS endpoint test to handle multiple cases
k-burt-uch Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions gen3-integration-tests/tests/test_drs_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,20 @@
"acl": ["jenkins"],
"size": 9,
},
"with_spaces": {
"file_name": "test_valid",
"urls": ["s3://cdis-presigned-url-test/test data"],
"hashes": {"md5": "73d643ec3f4beb9020eef0beed440ad0"},
"acl": ["jenkins"],
"size": 9,
},
"with_spaces_encoded": {
"file_name": "test_valid",
"urls": ["s3://cdis-presigned-url-test/test%20data"],
"hashes": {"md5": "73d643ec3f4beb9020eef0beed440ad0"},
"acl": ["jenkins"],
"size": 9,
},
"not_allowed": {
"file_name": "test_not_allowed",
"urls": ["s3://cdis-presigned-url-test/testdata"],
Expand Down Expand Up @@ -95,11 +109,13 @@ def test_get_drs_presigned_url(self):
1. Get the drs presgined url for indexd record (allowed).
2. Validate the content of the file checkout.
"""
signed_url_res = self.drs.get_drs_signed_url(file=indexd_files["allowed"])
self.fence.check_file_equals(
signed_url_res=signed_url_res.json(),
file_content="Hi Zac!\ncdis-data-client uploaded this!\n",
)
to_test = ["allowed", "with_spaces", "with_spaces_encoded"]
for test_case in to_test:
signed_url_res = self.drs.get_drs_signed_url(file=indexd_files[test_case])
self.fence.check_file_equals(
signed_url_res=signed_url_res.json(),
file_content="Hi Zac!\ncdis-data-client uploaded this!\n",
)

def test_get_drs_invalid_access_id(self):
"""
Expand Down
Loading