Skip to content

Update formatting string to see error message - #16

Merged
nss10 merged 1 commit into
main-gen3from
fix/format_error_logs
Aug 25, 2026
Merged

Update formatting string to see error message#16
nss10 merged 1 commit into
main-gen3from
fix/format_error_logs

Conversation

@nss10

@nss10 nss10 commented Aug 19, 2026

Copy link
Copy Markdown
With fmt.Sprintf
{"err":"rpc error: code = Internal desc = Plugin returned error: code: 500, message: error making HTTP request to 'http://gen3-workflow-service/storage/setup': %!w(*url.Error=&{Get http://gen3-workflow-service/storage/setup 0x1964740a38b0}), user: , task: <nil>","level":"debug","msg":"responding: /tes.TaskService/CreateTask","ns":"server","resp":null,"time":"2026-08-19T23:04:37Z"}

With fmt.Errorf
{"err":"rpc error: code = Internal desc = Plugin returned error: code: 500, message: error making HTTP request to 'http://gen3-workflow-service/storage/setup': Get \"http://gen3-workflow-service/storage/setup\": context deadline exceeded (Client.Timeout exceeded while awaiting headers), user: , task: <nil>","level":"debug","msg":"responding: /tes.TaskService/CreateTask","ns":"server","resp":null,"time":"2026-08-20T02:04:04Z"}

Link to JIRA ticket if there is one:

New Features

Breaking Changes

Bug Fixes

Improvements

  • fmt.Sprintf with %w produces a literal %!w(...) output instead of the error message. Replacing all fmt.Sprintf("...: %w", err) calls with fmt.Errorf("...: %w", err).Error() so that error messages are correctly expanded in the returned error responses.

Dependency updates

Deployment changes

@nss10
nss10 requested a review from paulineribeyre August 25, 2026 02:14
@nss10
nss10 merged commit 439bdc2 into main-gen3 Aug 25, 2026
4 checks passed
@paulineribeyre
paulineribeyre deleted the fix/format_error_logs branch August 25, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants