docs: fix Docker build command in README (no plain Dockerfile in repo root)#253
Closed
wcj007 wants to merge 1 commit into
Closed
docs: fix Docker build command in README (no plain Dockerfile in repo root)#253wcj007 wants to merge 1 commit into
wcj007 wants to merge 1 commit into
Conversation
The repo root has no plain Dockerfile (only Dockerfile.production, Dockerfile.config, Dockerfile.test), so "docker build ." fails. Specify the production Dockerfile explicitly. Fixes uc-cdis#251.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the Docker build command in the README. The repository root contains no plain
Dockerfile— onlyDockerfile.production,Dockerfile.config, andDockerfile.test. As a result the documented commanddocker build .fails with "unable to prepare context: unable to evaluate symlinks in Dockerfile path" / "failed to read dockerfile".Change
README.md(Docker section):Why
Following the maintainer's suggestion in #251 to point at one of the Dockerfile variants that actually exist in the repo root.
Dockerfile.productionis the production image build.Fixes #251.