Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iconCache: Gio.Icon.equal(), not .equals() #521

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Apr 15, 2024

The comparison function is named equal().
https://docs.gtk.org/gio/method.Icon.equal.html

Fixes this traceback:

Apr 14 17:15:41 gnome-shell[2368055]: 
remmina-icon unable to update icon: TypeError: oldIcon.equals is not a function
Stack trace:
add@file:///.../[email protected]/iconCache.js:52:34
_cacheOrCreateIconByName@file:///.../[email protected]/appIndicator.js:1074:37
async*_createIcon@file:///.../[email protected]/appIndicator.js:1440:38
_createAndSetIcon@file:///.../[email protected]/appIndicator.js:1400:32
_updateIconByType@file:///.../[email protected]/appIndicator.js:1392:24
_updateIcon@file:///.../[email protected]/appIndicator.js:1469:24
_invalidateIcon@file:///.../[email protected]/appIndicator.js:1524:14
_invalidateIconWhenFullyReady@file:///.../[email protected]/appIndicator.js:1507:18
async*_init/<@file:///.../[email protected]/appIndicator.js:915:24
_callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
reset@file:///.../[email protected]/appIndicator.js:698:14
_ensureItemRegistered@file:///.../[email protected]/statusNotifierWatcher.js:136:18
RegisterStatusNotifierItemAsync@file:///.../[email protected]/statusNotifierWatcher.js:205:24
_handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:373:35
_wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
@resource:///org/gnome/shell/ui/init.js:21:20

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Apr 15, 2024

Er, sorry. Wrong reference, right fix: https://docs.gtk.org/gio/vfunc.Icon.equal.html

(Edit: Fixed commit message.)

@ferdnyc ferdnyc changed the title iconCache: Gio.File.equal(), not .equals() iconCache: Gio.Icon.equal(), not .equals() Apr 15, 2024
@3v1n0 3v1n0 merged commit 7c0e7e1 into ubuntu:master Apr 18, 2024
1 check failed
@ferdnyc ferdnyc deleted the patch-1 branch April 20, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants