fix: sign manifest with cosign #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
tulilirockz
previously approved these changes
Feb 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tulilirockz
previously approved these changes
Feb 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This should allow us to enforce signatures during rebases and updates
tulilirockz
force-pushed
the
sign-image-manifest-with-cosign
branch
from
952d0fa to
81d6c3f
Compare
tulilirockz
previously approved these changes
Feb 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
castrojo
approved these changes
Feb 3, 2025
dosubot
bot
added
size:M
castrojo
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--enforce-container-sigpolicy is failing due to a missing signature.
This PR signs the manifests as well as the image, which should allow us to enforce signatures during rebases and updates.
Due to running the manifest step in a container, and Cosign not working well in said container, I've moved the sign step to a separate job which is completed after pushing the manifest.