chore: enable Fedora 42 akmods #308
Conversation
This will likely fail for the majority of akmods, but we need to start somewhere.
dosubot
bot
added
the
size:M
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for Fedora 42 akmods builds by introducing a new workflow and updating related configurations for existing Fedora versions.
- Added a new workflow file (.github/workflows/build-42.yml) for Fedora 42 builds.
- Adjusted schedule timings in build-41.yml and build-40.yml to accommodate the new build order.
- Updated descriptions in action and reusable workflow files to include Fedora 42 support.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/build-42.yml | New workflow file added for Fedora 42 builds. |
| .github/workflows/build-41.yml | Modified build schedule cron timing. |
| .github/actions/get-kernel-version/action.yml | Updated description and enabled debug output with 'set -x'. |
| .github/workflows/build-40.yml | Updated build schedule cron timing. |
| .github/workflows/reusable-build.yml | Updated input description for Fedora version to include 42. |
| KERNEL_RELEASE="$(echo "$kernel_version" | cut -d - -f 2 | cut -d . -f 1).$(echo "$kernel_version" | cut -d - -f 2 | cut -d . -f 2)" | ||
| KERNEL_RELEASE="$(echo "$kernel_version" | cut -d - -f 2 | rev | cut -d . -f 2- | rev)" |
There was a problem hiding this comment.
We needed to slightly rework this logic to support release candidate kernel versions.
"-rc-X" was removed from the original command, causing the lookup to fail.
There was a problem hiding this comment.
I like rev based solutions as they often end up being much simpler (and more correct) than mulitple cuts.
.github/workflows/build-40.yml
Outdated
There was a problem hiding this comment.
Reason for the change in time for the 40/41 cronjobs?
There was a problem hiding this comment.
This was because it seems like we build the newest version before the older ones, so wanted to follow the same pattern.
Didn't want to build any earlier since I think it lines up with when Fedora builds their images.
Therefore I shifted all existing workflows later by 20 minutes to slot the F42 builds where the F41 ones were originally.
| @@ -7,7 +7,7 @@ on: | |||
| paths-ignore: | |||
| - '**.md' | |||
| schedule: | |||
| - cron: '5 0 * * *' # 0005 UTC everyday | |||
| - cron: '25 0 * * *' # 0025 UTC everyday (20 minutes after 42) | |||
There was a problem hiding this comment.
Same here? Why the change in time?
| fedora_version: | ||
| - 42 | ||
| kernel_flavor: | ||
| - main |
Enables F42 akmods builds. Tweaks the schedules to keep up with conventions.
Needed to disable the following, since they are either broken or non-existent:
Asus and surface will be deprecated in F42, so not enabling these.