Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI errors #962

Merged
merged 12 commits into from
Jan 19, 2025
Merged

Fix CI errors #962

merged 12 commits into from
Jan 19, 2025

Conversation

JosephChotard
Copy link
Contributor

@JosephChotard JosephChotard commented Jan 18, 2025

LCOV

It seems that since lcov was upgraded to 2.0 actions have been failing

Last successful linux coverage test:
Unpacking lcov (1.15-1) ...
Now:
Unpacking lcov (2.0-4ubuntu2) ...

geninfo: ERROR: mismatched end line for main at /home/runner/work/h3/h3/src/apps/testapps/testBaseCells.c:23: 32 -> 23
	(use "geninfo --ignore-errors mismatch ..." to bypass this error)

I added --ignore-errors mismatch as that seems to be what people on other issues recommend.

Examples

For the example that was failing CI checks it seems it was due to use-of-uninitialized-value. I initialised the variables and seems to be good now

@JosephChotard JosephChotard marked this pull request as draft January 18, 2025 18:04
@JosephChotard
Copy link
Contributor Author

can't figure out why distance example keeps failing... I'm a C & gh actions noob

@JosephChotard
Copy link
Contributor Author

2/5 Test #2: distance .........................***Failed 0.22 sec
==9343==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x563864667785 in main (/home/runner/work/h3/h3/build/examples/bin/distance+0xcc785) (BuildId: a9036d3a023b790320c974930802c21cdf8dbfe0)
#1 0x7f513ea2a1c9 (/lib/x86_64-linux-gnu/libc.so.6+0x2a1c9) (BuildId: 6d64b17fbac799e68da7ebd9985ddf9b5cb375e6)
#2 0x7f513ea2a28a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2a28a) (BuildId: 6d64b17fbac799e68da7ebd9985ddf9b5cb375e6)
#3 0x5638645cf3b4 in _start (/home/runner/work/h3/h3/build/examples/bin/distance+0x343b4) (BuildId: a9036d3a023b790320c974930802c21cdf8dbfe0)

SUMMARY: MemorySanitizer: use-of-uninitialized-value (/home/runner/work/h3/h3/build/examples/bin/distance+0xcc785) (BuildId: a9036d3a023b790320c974930802c21cdf8dbfe0) in main
Exiting

@JosephChotard JosephChotard marked this pull request as ready for review January 18, 2025 21:27
@JosephChotard
Copy link
Contributor Author

@dfellis sorry for spam. Seems like I got it to work on my branch. Could you trigger CI checks?

@JosephChotard JosephChotard changed the title [WIP] Fix actions error Fix CI errors Jan 18, 2025
@dfellis dfellis requested a review from isaacbrodsky January 19, 2025 00:48
@isaacbrodsky isaacbrodsky merged commit 9a1f63b into uber:master Jan 19, 2025
38 checks passed
@JosephChotard JosephChotard deleted the jc/fix-h3-errors branch January 19, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants