Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for polygonToCellsExperimental #959

Merged

Conversation

isaacbrodsky
Copy link
Collaborator

Fixes #957

@coveralls
Copy link

coveralls commented Dec 24, 2024

Coverage Status

coverage: 98.784%. remained the same
when pulling 0a1eeba on isaacbrodsky:docs-polygonToCellsExperimental
into f5f5ab4 on uber:master.


```py
h3.polygon_to_cells_experimental(h3shape, res, flags='containment_overlapping')
h3.h3shape_to_cells_experimental(h3shape, res, flags='containment_overlapping')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only need one of these lines?

Copy link
Collaborator Author

@isaacbrodsky isaacbrodsky Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are aliases. I do note that in the other bindings I found it more obvious to name the enum PolygonToCellsFlags rather than ContainmentMode, but in Python I opened a PR with the ContainmentMode name.

@ajfriend ajfriend self-requested a review January 27, 2025 00:55
@ajfriend
Copy link
Contributor

Looks good comparing to uber/h3-py#436

@isaacbrodsky isaacbrodsky merged commit 61fba3d into uber:master Jan 27, 2025
38 checks passed
@isaacbrodsky isaacbrodsky deleted the docs-polygonToCellsExperimental branch January 27, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add polygonToCellsExperimental to the h3geo.org docs
4 participants