More type improvements #126
Merged
+258
−161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zxbodya
commented
Dec 3, 2025
zxbodya
commented
- more type improvements
- fix for namespace exports, to correctly include types
- enable type output for package publishing
This reverts commit 7abb348.
albertyw
approved these changes
Dec 3, 2025
Comment on lines
+5
to
+8
| export type Alert = _Alert; | ||
| export const Alert = _Alert; | ||
| export type Condition = _Condition; | ||
| export const Condition = _Condition; |
Member
There was a problem hiding this comment.
This is not an idiom in typescript that I'm familiar with. This works to export both the type and the var under the same name?
Contributor
Author
There was a problem hiding this comment.
It is a bit of a weird feature - as long as it does not conflict, TypeScript allows that
https://www.typescriptlang.org/docs/handbook/declaration-merging.html
In this case, the re-exported class is both a type (for instances of it) and a variable (a constructor function), and this is a workaround to have both (having just export const does not export the type)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.