Skip to content

Conversation

@zxbodya
Copy link
Contributor

@zxbodya zxbodya commented Oct 24, 2025

Converting sources to TypeScript, enabling type checks for JS files in the project.

Changing the TypeScript config to non-strict mode, for now. Looking to re-enable it once more types are added.

@zxbodya zxbodya force-pushed the minimal-ts-coverage branch from 0f59fac to 2d0aec6 Compare October 24, 2025 22:03
@zxbodya zxbodya marked this pull request as ready for review October 24, 2025 22:04
@albertyw
Copy link
Member

Now that we're adding types into the repo, we should be testing types. I see npm run build in the CI config but that tests using tsconfig.build.json. There doesn't seem to be a build step that tests against tsconfig.json.

@albertyw albertyw merged commit a224d20 into uber:master Oct 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants