Remove the pygam dependency and allow latest versions of Cython, numpy, scipy, scikit-learn #812
+14
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes #796 by removing
pygam
frompyproject.toml
. It also removes the upper version restrictions forCython
,numpy
,scipy
andscikit-learn
.pygam
with the Isotonic calibration inscikit-learn
and allowed to use the latestscipy
,Cython
, andnumpy
.xgboost==2.1.4
release resolved the compatibility issue withscikit-learn==1.6
in Adapt to scikit-learn 1.6 estimator tag changes dmlc/xgboost#11021 and allowed to use the latestscikit-learn
.noexcept
modifier has been added to the Cython code to comply withCython 3.x
(ref)Types of changes
What types of changes does your code introduce to CausalML?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
N/A