Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config that sets pre-push hook #292

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove config that sets pre-push hook #292

wants to merge 2 commits into from

Conversation

aasthayadav
Copy link

Current:
Repo owners who do not set "uber.diff.git.push.verify": true by default are not running pre-push hook on git push.
This is not the default in git and just like all other git hooks, pre-push hooks should run.

After this change:
"uber.diff.git.push.verify" config would not let you override running pre-push hooks.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@uberSri uberSri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default behavior should verify. Lgtm except for comment.

src/workflow/ArcanistDiffWorkflow.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants