Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Variable Shadowing and using fixed length slice #422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent Variable Shadowing and using fixed length slice #422

wants to merge 1 commit into from

Conversation

architagr
Copy link

@architagr architagr commented Jan 24, 2025 •
edited
Loading

This MR I observed some cosmetic issues listed below to avoid common anti-patterns:

  • Avoid Variable Shadowing. (better code readability)
  • No defer statement in the for loop.
  • Avoid using append on a slice, whose length is known, it saves calling some build-in function. (minor performance improvement)

@architagr
update code to save shadow variable name and also prevent using appen…
4088040 
…d when we already know the size of the slice
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@architagr architagr changed the title Save shadow variable name and also prevent using append on fixed sized slice Prevent Variable Shadowing and using fixed length slice Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@architagr @CLAassistant