Skip to content

Conversation

cecilialau6776
Copy link
Contributor

@cecilialau6776 cecilialau6776 commented Oct 2, 2025

Fixed some tests

  • Project view tests
    • ProjectUserDetail expects a ProjectUser pk, but the test provides a User pk. This PR fixes that and provides the correct pk.
  • AllocationChangeViewTest
    • The AllocationChangeViewTest set the url to "/allocation/1/change-request". This PR changes it to f"/allocation/{self.allocation.pk}/change-request", fixing a 404 reply.
  • ProjectListViewTest.test_project_list_search
  • coldfront.core.allocation.tests.test_models
    • Untested; couldn't reproduce original bug
    • Replaced timezone.now() calls in test_models.py with datetime.date.now(), since that's what the model uses.

replaced `timezone.now()` calls in test_models.py with
`datetime.date.now()`, since that's what the model uses

Signed-off-by: Cecilia Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: coldfront.core.project.test_views.ProjectListViewTest.test_project_list_search is Flaky
1 participant