Bug fix allocation account #792
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aced ALLOCATION_ACCOUNT_ENABLED constant with call to settings to enable testing updated user test for pi status to enable testing created tests for AllocationAccountCreateView Signed-off-by: Chris Barnett <[email protected]> update creation of pi user in test setup to set userprofile.is_pi to True Signed-off-by: Chris Barnett <[email protected]>
csbarnet
force-pushed
the
bug-fix-allocation-account
branch
from
727c8d0 to
39fd83a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue reported here: #791
It also adds tests for this view.
A couple of things worth noting:
Although the main change was the change from 'request.is_ajax' to 'request.get("x-requested-with") == "XMLHttpRequest"', a couple of changes were made to enable testing.
I changed the way ALLOCATION_ACCOUNT_ENABLED was accessed from settings to enable testing. Originally, this value is assigned to a constant at the top of the file, so that it is only evaluated on import. However, this view is only accessible when this setting is assigned the non-default value. Using 'import_from_settings' in the view allows us to inject different values for the setting at test time using the 'override_settings' annotation.
I also changed the setup in the test for creation of the pi user to enable request.user.userprofile.is_pi to return True for a PI user.