Skip to content

Conversation

ds-04
Copy link
Contributor

@ds-04 ds-04 commented Sep 8, 2025

This PR enhances the auto_compute_allocation plugin with the following changes:

  • Ability to add accelerator hours (gauge) for both training and non-training projects
  • Ability to add slurm attributes via ENV tuple for both training and non-training projects
  • Control slurm account naming via a string
  • Some limited control of institution fairshare naming (similar to slurm account naming) via a string
  • README.md updates and improvements
  • Consistent use of the word institution rather than institute

N.B. there is overlap between the variables that can be used to define the custom strings for:

AUTO_COMPUTE_ALLOCATION_FAIRSHARE_INSTITUTION_NAME_FORMAT
AUTO_COMPUTE_ALLOCATION_SLURM_ACCOUNT_NAME_FORMAT

... this is intentional and provides ease of maintenance - by using two separate files/functions to perform these.


tagging @cecilialau6776

Copy link
Contributor

@cecilialau6776 cecilialau6776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I don't see a particular reason to put fairshare_institution_name and slurm_account_name in their own files instead of in utils.py. Looks good otherwise


...specifically for training (field of science = training) projects with:

- ``AUTO_COMPUTE_ALLOCATION_ACCELERATOR_HOURS``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing _TRAINING?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks will amend README to add _TRAINING

the separate files were used for ease of maintenance and to avoid a bloat of the utils.

@ds-04 ds-04 force-pushed the auto_compute_allocation_september_2025 branch 2 times, most recently from 512c59e to 1b8833d Compare September 8, 2025 16:17
@ds-04
Copy link
Contributor Author

ds-04 commented Sep 8, 2025

Should now be ready - minor changes were made it the 2x force pushes ...

  1. _TRAINING in README
  2. string not dict in comment

@ds-04
Copy link
Contributor Author

ds-04 commented Oct 3, 2025

there's possibility a problem with a config/env var ... I'm working on establishing if that definitely is the case

(an import error)

…ng control

Signed-off-by: David Simpson <David Simpson>
@ds-04 ds-04 force-pushed the auto_compute_allocation_september_2025 branch from 1b8833d to 81a61bb Compare October 6, 2025 09:21
@ds-04
Copy link
Contributor Author

ds-04 commented Oct 6, 2025

@aebruno i think this is ready now, the last force commit fixed the error in the plugin's defaults ... a typo had crept in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants