Replace doi2bib with a util function to remove future package dependency #770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the functionality of the
git_bib
function fromdoi2bib
.This is mainly to address CVE-2025-50817 --
doi2bib
uses thefuture
package anddoi2bib
appears to no longer be actively maintained. It appears to me that the functionality being used in ColdFront is a simple url request to the crossref.org rest api so just re-implement that.Note: the following have not been updated (but should be).
the tests in publication will no longer work as written (I didn't fully comprehend what it was actually doing, but I can circle back when I have more time available and try to update them)The packagesdoi2bib
andfuture
should no longer be dependencies in theuv
file. I'm still running an older version usingsetup.py
/requirements.txt
, so I didn't test. My assumption is that is a trivial change.