Switch to pyproject.toml #648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmarr Thanks for the PR. We're definitely interested in converting fully to pyproject.toml. This looks like a great start. Testing this now and will provide any feedback.
This would be great. We're testing out uv now and will likely start using it more in the future. Would be very interested in your Dockerfile if you're willing to share. Thanks! |
Converts from setup.py to pyproject.toml and removes setup.py Adds ldap authentication deps to optional "auth" group Signed-off-by: pmarr <[email protected]>
The container image uses the python alpine image and uv to compile the
project deps then the project itself. These are copied into a minimal,
unprivileged stage.
docker/podman compose is used to spin up the resulting container.
We use uv in the Dockerfile for dependency resolution and faster builds.
A combination of pyproject.toml and uv.lock replaces the need for pip
and manually managing venv environement variables.
Run `uv lock` to regenerate lockfile from pyproject.toml
Start with
podman compose -f compose.yml up -d
Stop with
podman compose down
Helpful commands
podman compose logs app
podman exec -it app sh
podman exec -it app coldfront initial_setup
Dockerfile - Replace upstream with uv based multi-stage build
|
Rebased from main and added multi-stage uv Dockerfile and requisite uv.lock file. Commit message has build instructions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts from setup.py to pyproject.toml and removes setup.py
It enables support of other pip backends besides setuptools like poetry or uv
Adds optional dependency groups allowing conditional installs of plugin dependencies.
If interested, I can submit a PR with our production Dockerfile. We build the coldfront project with uv in a minimal, unprivileged container.
Is there any reason upstream would want to stay with setup.py?