chore: regenerate per-submodule NOTICE files for parent v51 + lang3#112
Merged
Merged
Conversation
Problem: uPortal-Project#111 regenerated the root NOTICE for the parent v51 + commons-lang -> commons-lang3 work but missed the per-submodule NOTICE files. Running `mvn notice:check` on master fails on courses-portlet-api with 'Existing NOTICE file ... doesn't match expected NOTICE file', which would block `mvn release:prepare` for 2.1.1. Goal: bring every reactor module's NOTICE in sync with its actual dep tree so notice:check passes across the full reactor. Changes: - courses-portlet-api/NOTICE, courses-portlet-dao/NOTICE, courses-portlet-webapp/NOTICE: regenerated via `mvn notice:generate` to pick up the post-v51 license metadata (Apache Commons Lang under Apache-2.0; Joda-Time / SLF4J license-name normalization). - Verified `mvn notice:check` is now green on all four reactor modules (root + 3 submodules).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #111 — that PR regenerated the root NOTICE for the parent v51 + commons-lang3 work, but missed the per-submodule NOTICEs. Running `mvn notice:check` on current master fails on `courses-portlet-api`, which would block `release:prepare` for 2.1.1.
This PR brings the three submodule NOTICEs in sync with their actual dep trees post-v51 (license-name normalization: "Apache Commons Lang under Apache-2.0" vs the older "Commons Lang under The Apache Software License, Version 2.0", same for Joda-Time and SLF4J).
Test plan