Repository navigation
fix(properties): replace default-font-id datalist with a select - #81
Merged
Merged
Conversation
The text input with list="zpl-default-font-ids" hit a browser datalist quirk: after a datalist suggestion has been picked and the component re-renders (e.g. when a Labelary preview kicks in), Chrome and Firefox keep the previous suggestion bound to the input and the next keystroke gets discarded. The field looked editable but onChange stopped firing. Replaces the input with a real select that lists the same union of font IDs (built-ins + every ^CW alias + every preview binding), plus an explicit "(none)" option for clearing the default. Selects do not carry the autocomplete state that broke the datalist input, so the field stays responsive across re-renders. Drops the now-unused datalist element and adds the new label.defaultFontIdNone locale key across all 32 locales.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the text input and datalist for the default font ID with a select dropdown in the Properties Panel. It also introduces a 'none' option for the font selection and adds the corresponding translation key 'defaultFontIdNone' across multiple locale files. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.