Repository navigation
refactor(canvas): compute 1D bwip scale per case instead of via cast - #40
Merged
Merged
Conversation
buildBwipOptions previously read moduleWidth at the top via
`(obj.props as { moduleWidth?: number }).moduleWidth ?? 2`, accepting an
unused fallback for 2D types that don't declare moduleWidth. With a small
`bwipScale1D` helper, each 1D case computes its scale from the narrowed,
required-typed `p.moduleWidth` directly. Eliminates the cross-type cast
and the dead-looking `?? 2` fallback at this site.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the 1D barcode scale calculation in bwipHelpers.ts by introducing a new helper function, bwipScale1D. This helper is now called within individual barcode type cases in buildBwipOptions, replacing a centralized calculation. This change improves type safety by allowing per-type property access and simplifies the main function logic. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildBwipOptions previously read moduleWidth at the top via
(obj.props as { moduleWidth?: number }).moduleWidth ?? 2, accepting an unused fallback for 2D types that don't declare moduleWidth. With a smallbwipScale1Dhelper, each 1D case computes its scale from the narrowed, required-typedp.moduleWidthdirectly. Eliminates the cross-type cast and the dead-looking?? 2fallback at this site.